fix(deps): downgrade Microsoft.CodeAnalysis packages to 5.0.0#316
Merged
Conversation
- Adjusted versions of Microsoft.CodeAnalysis, Analyzers, Common, and CSharp from 5.3.0 to 5.0.0 - Ensures compatibility with existing project dependencies
ncipollina
approved these changes
Mar 23, 2026
- Updated System.Text.Json version to [8.0.6, 9.0.0) to ensure compatibility and future-proofing - Applies only to netstandard2.0 target framework
…lysis' into bug/downgrade-microsoft-code-analysis
j-d-ha
marked this pull request as draft
March 23, 2026 15:01
- Updated Microsoft.CodeAnalysis.Analyzers to version 5.3.0 - Adjusted Microsoft.CodeAnalysis, Common, and CSharp to use version range [5.0.0] - Ensures compatibility with project dependencies and resolves versioning issues
- Removed Microsoft.CodeAnalysis.Common from project and central package configs - Consolidated usage under Microsoft.CodeAnalysis.CSharp where applicable - Simplifies dependency tree and avoids redundant package references
j-d-ha
marked this pull request as ready for review
March 23, 2026 15:07
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 87.34% 87.38% +0.03%
==========================================
Files 113 113
Lines 2814 2814
Branches 351 351
==========================================
+ Hits 2458 2459 +1
+ Misses 255 254 -1
Partials 101 101 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
Microsoft.CodeAnalysis*packages from5.3.0to5.0.0.Microsoft.CodeAnalysis.CSharp5.3.0 introduced a regression (dotnet/roslyn#82780) where source-generator-produced interceptors are silently not applied by the compiler — the interceptor file is generated successfully but the original method executes instead of the intercepted one.✅ Checklist
🧪 Related Issues or PRs
💬 Notes for Reviewers
This is a temporary pin. Once the Roslyn team ships a fix, we should upgrade again. The only file changed is
Directory.Packages.props— four package version entries.